Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element group for selected element #832

Merged
merged 16 commits into from Nov 7, 2023

Conversation

OlegMoshkovich
Copy link
Member

This PR introduces a new "Element Group" feature at the bottom of the screen.
The group encompasses controls for the following functionalities:

Cutplane
Isolating selected element
Hiding selected element
Deselecting an element
Unhiding all of the hidden elements

Behavioral Notes:
The majority of these controls become active only when an element is selected.
In its neutral or default state, only the cutplane control is visible and accessible.

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 76405df
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/654aafe4a2bc5c0008f657f6
😎 Deploy Preview https://deploy-preview-832--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 3 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich marked this pull request as draft November 4, 2023 09:27
Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 76405df
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/654aafe48610e90008657872
😎 Deploy Preview https://deploy-preview-832--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter
Copy link
Member

pablo-mayrgundter commented Nov 7, 2023

w00t!

  • Love isolate
  • Feeling a little bare.. maybe we should start with nav open and root elt selected so that props are visible? And maybe no in mobile if it's too crowded there
  • Props and info have same icon. Can we go back to usual hamburger props icon? it's very recognizable to me
  • Clear is both in the Section menu and in the Element button group, but not when just Sectioned. Can you have it always be part of Element group when clear is valid?
  • Did Help tooltips get cleaned up? They look nice!

Did a first scan of code. Looking good.

@pablo-mayrgundter
Copy link
Member

Draft or no?

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review November 7, 2023 15:10
@OlegMoshkovich
Copy link
Member Author

image

Clearing of plane was moved to the plane menu.

@pablo-mayrgundter
Copy link
Member

Per convo, starting with Nav open we're going to punt.

@OlegMoshkovich OlegMoshkovich merged commit e8c8555 into bldrs-ai:main Nov 7, 2023
13 checks passed
@OlegMoshkovich OlegMoshkovich deleted the element_group branch November 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants