Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace write-new-version for package.json similar to conway. #833

Merged
merged 5 commits into from Nov 7, 2023
Merged

Replace write-new-version for package.json similar to conway. #833

merged 5 commits into from Nov 7, 2023

Conversation

pablo-mayrgundter
Copy link
Member

See https://github.com/bldrs-ai/conway/pull/75

  • add one to revision count
  • do in-place rewrite
  • self-execute
  • move to scripts directory with corresponding name

@pablo-mayrgundter
Replace write-new-version package script: add one to revision count, …
3ae9550 
…do in-place rewrite, self-execute, move to scripts directory with corresponding name.
@pablo-mayrgundter pablo-mayrgundter added the code Code cleanup, refactoring, style and lint label Nov 6, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 5eb5953
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/654aa0be5956b90008096128
😎 Deploy Preview https://deploy-preview-833--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 26 (🔴 down 4 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter marked this pull request as draft November 6, 2023 23:50
@pablo-mayrgundter
Copy link
Member Author

Whoops, some tests expect the version string in a different format

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023 •
edited

✅ Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 5eb5953
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/654aa0bed2239d00084899b2
😎 Deploy Preview https://deploy-preview-833--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter marked this pull request as ready for review November 6, 2023 23:56
@pablo-mayrgundter pablo-mayrgundter changed the title Replace write-new-version similar to conway. Replace write-new-version for package.json similar to conway. Nov 7, 2023
@pablo-mayrgundter
Copy link
Member Author

@nickcastel50 ptal

nickcastel50
nickcastel50 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-mayrgundter pablo-mayrgundter merged commit 1c01767 into bldrs-ai:main Nov 7, 2023
13 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the version branch November 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickcastel50 nickcastel50 nickcastel50 approved these changes

@OlegMoshkovich OlegMoshkovich Awaiting requested review from OlegMoshkovich

@oo-bldrs oo-bldrs Awaiting requested review from oo-bldrs

Assignees

@nickcastel50 nickcastel50

Labels
code Code cleanup, refactoring, style and lint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pablo-mayrgundter @nickcastel50 @oo-bldrs