Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props3 #84

Merged
merged 7 commits into from Jan 29, 2022
Merged

Props3 #84

merged 7 commits into from Jan 29, 2022

Conversation

pablo-mayrgundter
Copy link
Member

So, here's a forked branch PR to main.

Check out the PSets here:
https://pablo-mayrgundter.github.io/Share/

@@ -1,6 +1,6 @@
{
"name": "buildrs",
"version": "0.1.0-r237",
"version": "0.1.0-r230",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter interesting the version went back.

})


test('decodeIfcString', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

// TODO(pablo): just found out this method is getting called a lot
// when i added navigation on select, which flooded the browser
// IPC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/

This was referenced Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants