Improve 404 bounce logic for GHPages serving. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest testing working again.
|
I made a mistake.. this was the merge of upstream into my fork to prepare for the bounce changes. They're coming next. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permalinks now work in our forked pages:
https://pablo-mayrgundter.github.io/Share/84/103/138/160/93485
And also happened to fix Firefox, which wasn't working at all with previous approach. Tested in Safari too.
Firefox local <-> esbuild server doesn't work.. it's mystifying. But I found out it wasn't working before either, so I think this is a strict improvement overall.
I'm not sure until we put it up at bldrs.ai whether it will work there.