Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagine control that includes link to discord channel #866

Merged
merged 20 commits into from Nov 30, 2023

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Nov 20, 2023

This PR aims to enhance the user experience for AI rendering from bldrs.ai by providing easy access to our discord bot.

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 421cc39
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6568b65bb60c060008d8c342
😎 Deploy Preview https://deploy-preview-866--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🟢 up 25 from production)
Accessibility: 83 (🔴 down 8 from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 421cc39
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/6568b65b1e97bf0008c137d4
😎 Deploy Preview https://deploy-preview-866--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review November 21, 2023 11:34
@OlegMoshkovich OlegMoshkovich added the story UX task from a Milestone/Shortcut story label Nov 21, 2023
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some text changes suggested, but didn't search for all occurrences. Let's discuss as needed and then also changes to be applied throughout

src/Components/HelpControl.jsx Show resolved Hide resolved
src/Components/ImagineControl.jsx Outdated Show resolved Hide resolved
src/Components/ImagineControl.jsx Outdated Show resolved Hide resolved
src/Components/ImagineControl.jsx Outdated Show resolved Hide resolved
src/Components/ImagineControl.jsx Outdated Show resolved Hide resolved
src/Components/ImagineControl.jsx Outdated Show resolved Hide resolved
@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL!

@pablo-mayrgundter
Copy link
Member

Can you reply to my comments saying if they're done and any notes?

@OlegMoshkovich
Copy link
Member Author

left a response under each comment

@pablo-mayrgundter
Copy link
Member

Heya, all looking good except seeing a new warning on console.

It's coming from inside React Dev Tools setup, so going to be a pain to find, but will be harder once merged. Can you bisect code a bit and see if you can find?

image

@OlegMoshkovich
Copy link
Member Author

Ok!thank you for finding it. Will take a look tomorrow.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we get this from HEAD with no code diffs, it's not related to these PRs.

LGTM

@OlegMoshkovich OlegMoshkovich merged commit 0885bf2 into bldrs-ai:main Nov 30, 2023
13 checks passed
@OlegMoshkovich OlegMoshkovich deleted the add_link_to_bot branch February 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story UX task from a Milestone/Shortcut story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants