Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a user menu which includes the option to log in and the theme control #870

Merged
merged 9 commits into from Nov 30, 2023

Conversation

OlegMoshkovich
Copy link
Member

No description provided.

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 3caca33
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6568caf63dc38f000899d6ae
😎 Deploy Preview https://deploy-preview-870--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🟢 up 25 from production)
Accessibility: 83 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 3caca33
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/6568caf635fc890008252529
😎 Deploy Preview https://deploy-preview-870--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review November 27, 2023 13:02
@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lighthouse is reporting some errors.. and when I dig in I see them as well in console:

image image image

@pablo-mayrgundter pablo-mayrgundter added the enhancement New feature or request label Nov 27, 2023
@OlegMoshkovich
Copy link
Member Author

It should be addressed.

@pablo-mayrgundter
Copy link
Member

Hmm, same react warning as bot link PR..

Hopefully that's a clue! Anything that's in both but not yet in prod?

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in 866, the react warning not related to this PR. LGTM

@OlegMoshkovich OlegMoshkovich merged commit 521c187 into bldrs-ai:main Nov 30, 2023
13 checks passed
@OlegMoshkovich OlegMoshkovich deleted the login_menu branch February 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants