Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-script-os package via yarn + fix windows compilation #872

Merged
merged 2 commits into from Nov 27, 2023

Conversation

nickcastel50
Copy link
Contributor

  • This PR address fixing windows compilation, the syntax we were using for setting the USE_WEBIFC_SHIM environment variable wasn't valid Windows syntax.

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 87625ee
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65650f8724d7f60007d47470
😎 Deploy Preview https://deploy-preview-872--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 87625ee
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65650f87c8c3a90008df7cac
😎 Deploy Preview https://deploy-preview-872--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will handoff to @oo-bldrs

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked w/nick, he's confident so we'll go ahead

@nickcastel50 nickcastel50 merged commit 453863f into bldrs-ai:main Nov 27, 2023
13 checks passed
@nickcastel50 nickcastel50 deleted the windows_compilation branch November 27, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants