Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce test-tools for esbuild config valiation. #976

Merged
merged 5 commits into from Feb 8, 2024

Conversation

pablo-mayrgundter
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter commented Feb 8, 2024

  • Add unit test for esbuild to validate only production config gets checked in.

And some cleanup:

  • Simplify common.js to just export the config instead of separate build step.
  • Disable console logging during test.
  • Remove analysis from regular runs but add new pkg script for it

Tested locally and verified in GH actions.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit dce0b9f
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65c525a274486c0008690459
😎 Deploy Preview https://deploy-preview-976--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 80 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit dce0b9f
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65c525a2a8402200083c1147
😎 Deploy Preview https://deploy-preview-976--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…d step. Disable console logging during test. Remove analysis from regular runs but add new pkg script for it. Tested locally.
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-mayrgundter pablo-mayrgundter merged commit ca2e266 into bldrs-ai:main Feb 8, 2024
13 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the test-tools branch February 8, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants