New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github + OPFS delete + OPFS tests #977
Merged
nickcastel50
merged 12 commits into
bldrs-ai:main
from
nickcastel50:OPFS_Delete_FileExists
Feb 9, 2024
Merged
Github + OPFS delete + OPFS tests #977
nickcastel50
merged 12 commits into
bldrs-ai:main
from
nickcastel50:OPFS_Delete_FileExists
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bldrs-share-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pablo-mayrgundter
requested changes
Feb 8, 2024
pablo-mayrgundter
requested changes
Feb 9, 2024
pablo-mayrgundter
approved these changes
Feb 9, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code (currently not hooked up to UI) for deleting models from OPFS and GitHub. It also adds a utility function to check to see if a file exists in OPFS.
Additionally, tests have been added for all OPFS related functions and the service worker has been mocked.