Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken model load on private LFS from break in OPFS, also Ver… #995

Merged
merged 1 commit into from Feb 22, 2024

Conversation

pablo-mayrgundter
Copy link
Member

…sions would have been broken for using finalUrl (LFS URL) for branch path composition. Fix Notes/Octokit race on non/authed init.

…sions would have been broken for using finalUrl (LFS URL) for branch path composition. Fix Notes/Octokit race on non/authed init.
@pablo-mayrgundter pablo-mayrgundter added the bug Something isn't working label Feb 22, 2024
@pablo-mayrgundter pablo-mayrgundter self-assigned this Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit e494c1a
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65d7b6cb888a9200087d08ab
😎 Deploy Preview https://deploy-preview-995--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 80 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit e494c1a
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65d7b6cbfc67380008f0fcc9
😎 Deploy Preview https://deploy-preview-995--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter merged commit 3fe4fe1 into bldrs-ai:main Feb 22, 2024
13 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the prod-fixes branch February 22, 2024 21:11
Copy link

sentry-io bot commented Feb 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ HttpError: Not Found getLatestCommitHash(src/utils/GitHub) View Issue
  • ‼️ TypeError: Cannot read properties of null (reading 'geometry') {_IfcIsolator#2}.setModel(src/Infrastructure/If... View Issue
  • ‼️ Error: Security error when calling GetDirectory listener(src/OPFS/utils) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants