Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zsh, fish & python cleaners. #1229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add zsh, fish & python cleaners. #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7395b5d
Add zsh.xml cleaner
Jul 16, 2021
d4ea92a
Add fish.xml cleaner
Jul 16, 2021
67ac349
Add python.xml cleaner
Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions cleaners/fish.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

BleachBit
Copyright (C) 2008-2021 Andrew Ziem
https://www.bleachbit.org

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.

-->
<cleaner id="fish" os="unix">
<label>Fish</label>
<description>Shell</description>
<option id="history">
<label>History</label>
<description>Delete the command history</description>
<action command="delete" search="file" path="~/.local/share/fish/fish_history"/>
</option>
</cleaner>
30 changes: 30 additions & 0 deletions cleaners/python.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

BleachBit
Copyright (C) 2008-2021 Andrew Ziem
https://www.bleachbit.org

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.

-->
<cleaner id="python" os="unix">
<label>Python</label>
<description>Programing language</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description>Programing language</description>
<description>Programming language</description>

<option id="history">
<label>History</label>
<description>Delete the command history</description>
<action command="delete" search="file" path="~/.pythonhist"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which system are you testing on? On Ubuntu 22.04, I have ~/.python_history. Please add this one.

</option>
</cleaner>
30 changes: 30 additions & 0 deletions cleaners/zsh.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99+% of Linux users do not use zsh or fish, so please submit those to https://github.com/bleachbit/cleanerml/ . Otherwise, I can accept it here and move them afterwards.

Bash is preinstalled on a typical Linux system, and here is a reference point
https://trends.google.com/trends/explore?geo=US&q=zsh,bash


BleachBit
Copyright (C) 2008-2021 Andrew Ziem
https://www.bleachbit.org

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.

-->
<cleaner id="zsh" os="unix">
<label>Zsh</label>
<description>Shell</description>
<option id="history">
<label>History</label>
<description>Delete the command history</description>
<action command="delete" search="file" path="~/.zsh_history"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same location on Ubuntu 22.04

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://www.redhat.com/sysadmin/favorite-shell Bash takes 779/1441=54% and Zsh 377/1441=26%

These are users who would go through the process of installing BleachBit.

</option>
</cleaner>