Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deleting autofill data in Chrome-like browsers. #1535

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

rados
Copy link
Contributor

@rados rados commented Sep 3, 2023

No description provided.

@az0 az0 added this to the 4.6 milestone Sep 4, 2023
@az0 az0 self-assigned this Sep 4, 2023
@az0
Copy link
Member

az0 commented Sep 4, 2023

@rados Thank you for working on this.

If a user has an old database version, probably because he uninstalled a Chrome-based browser before it updated the database, then the new code will keep erroring on the old database, so a solution would be to modify __shred_sqlite_char_columns() to check that each column exists like __sqlite_table_exists().

Let me know the next time you can work on this, and depending on our schedules, I may work on it.

For now, I will ask some users (with the new database) to test this.

@rados
Copy link
Contributor Author

rados commented Sep 4, 2023

@az0 Yes, I've missed this case, thank you. According to my observations the whole tables 'local_addresses' and 'local_addresses_type_tokens' are part of the new db, so it will be enough to check if the tables exist. I can push this change quickly.

@az0 az0 merged commit 5a83a67 into bleachbit:master Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment