Utf8filenames #154
Utf8filenames #154
Conversation
| @@ -1,26 +1,33 @@ | |||
| build: off | |||
| version: 1.13.{build} | |||
There was a problem hiding this comment.
Could we please note hard code the version number?
There was a problem hiding this comment.
Appveyor does not accept fixed version, it must be dynamic !
| check_exist(NSIS_EXE, 'NSIS executable not found: will try to build portable BleachBit') | ||
|
|
||
|
|
||
| #if not fast: |
There was a problem hiding this comment.
This section is commented out. Is there a problem with it?
|
|
||
| logger.info('Checking for Linux-only cleaners') | ||
| if os.path.exists( 'dist\\share\\cleaners\\wine.xml'): | ||
| logger.info('grep -l os=.linux. dist/share/cleaners/*xml | xargs rm -f') |
There was a problem hiding this comment.
Rather than just logging the grep command, would you please actually delete all files in dist/share/cleaners/*xml that match the pattern os="linux"?
| shutil.rmtree( 'dist\\library', ignore_errors=True ) | ||
| assert_exist( 'dist\\library.zip') | ||
|
|
||
| logger.info('Building portable') |
There was a problem hiding this comment.
I can see you carefully followed setup_py2exe.bat, but it seems to have a bug. If you don't mind, please build the portable regardless of the setting of the variable fast
|
|
||
|
|
||
| logger.info('Purging unnecessary GTK+ files') | ||
| cmd= sys.executable + ' setup.py clean-dist' |
There was a problem hiding this comment.
Regarding the log like this
warning: msgunfmt missing: skipping recompile
https://ci.appveyor.com/project/az0/bleachbit/build/1.13.285#L798
Here would you please enable msgunfmt to work?
|
Looking good. The error for Python 2.6 can be ignored as currently BleachBit is on 2.7 and Python 3 is coming a long better then anyone expected it to be (unless you feel like fixing it just for the heck of it). |
add windows build script
add appveyor build script