Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved windows_explorer.xml file #445

Closed

Conversation

Tobias-B-Besemer
Copy link
Contributor

No description provided.


<!-- Completely deleted by CCleaner !!!
<action command="winreg" path="HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\ComDlg32"/>
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate on this commented out action and your comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just a note as a kind of documentation... This line was for my opinion to hard, so I don't included it... Maybe a later editor of the cleaner will include this line... So he have "some docus" from me to it...

@az0 az0 modified the milestones: 2.2, 2.4 Feb 27, 2019
@az0
Copy link
Member

az0 commented Feb 27, 2019

I marked this for milestone 2.4 (instead of 2.2) to avoid delaying the 2.2 release any more. This could use careful review and testing.

@az0 az0 modified the milestones: 2.4, 3.0 Apr 13, 2019
<action command="winreg" path="HKCU\Software\Microsoft\Direct3D\MostRecentApplication" name="Name"/>
<action command="winreg" path="HKLM\Software\Microsoft\DirectDraw\MostRecentApplication"/>
<action command="winreg" path="HKCU\Software\Microsoft\DirectInput\MostRecentApplication" name="Id"/>
<action command="winreg" path="HKCU\Software\Microsoft\DirectInput\MostRecentApplication" name="Name"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do Direct3D, DirectDraw, and DirectInput have to do with Windows Explorer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used winsys.ini as a reference...

2019-07-17 02_53_48-winsys ini - Editor

<option id="mountpoints2">
<label>Mount Points</label>
<description>Delete the data</description>
<warning>Use the option only if you know what you do!</warning>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't immediately obvious to me what this does, but it sounds scary, so maybe it shouldn't be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@az0
Copy link
Member

az0 commented Sep 8, 2019

Thank you for your work putting this together. However, please let's not use CCleaner's winsys.ini as a reference for any pull requests here, so I need to close this pull request. You may resubmit a new PR with that part removed or based on another reference.

@az0 az0 closed this Sep 8, 2019
@Tobias-B-Besemer
Copy link
Contributor Author

I used winsys.ini as a reverence, but verified got all on my long time used testing machine (~10 years) with "reverse engineering" e.g. the registry keys. So all implemented cleaning was verified and tested on my machine.
OK, I understand that using other cleaners as inspiration to look on special things in the system is not so good... but as I have now the knowledge from analysing, I can use this knowledge, right?
So I would do a split into two cleaners, one "Explorer" and one "DirectX"... Would this work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants