-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added windows crashdumps cleaner #86
Conversation
There is a entry in Winapp2 that looks very similar to this: [Memory Dumps] This was one of the entries taken out of Winapp2 and was re-added to BleachBit specifically. I suppose we can move it to CleanerML, but then I suggest you add the other FileKeys and then remove it from Winapp2. |
c4e9ce7
to
4adb681
Compare
What can we do here? |
Since it is no longer under Winapp2 care, I would suggest moving it to CleanerML. |
Winapp2 was Never more than an option for bleachbit. |
Feel free to take any extra entries from the Winapp2 one and move it to your CleanerML and I will edit the Winapp2 file here on github and remove the entry out of there. I think it should be done to all the entries that got removed from Winapp2 that we re-added in a modified copy of Winapp2. They should all be in CleanerML instead. |
Yes, it looks like this could be a simple cleaner written in CleanerML. Because it affects so many Windows systems, though, I would like to merge it in this repository instead. If the cleaner were named windows.xml, it would be a good place to move more of the cleaning options out of Python and into CleanerML. In case you like to take to attempt it, I will leave this PR open. |
As someone who fixes Windows systems for a living I'd ask that you only take out dumps that are old, say at least a year old. |
This pull request is not needed anymore. The removed entries have been moved back to the main Winapp2 respo and are managed by the community again. See here: https://github.com/MoscaDotTo/Winapp2/tree/master/Non-CCleaner You can go ahead and close this. |
Closing because of comment "This pull request is not needed anymore. " |
UNTESTED!!
havent had the time to look into how to compile, yet. @az0 can you test that one?