Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Leftovers.xml - Windows #274

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Driver Leftovers.xml - Windows #274

merged 4 commits into from
Apr 28, 2022

Conversation

Chaython
Copy link
Contributor

@Chaython Chaython commented Jul 15, 2020

A cleanerml xml to delete AMD/Nvidia and other driver installation media.
https://github.com/Chaython/Driver-cleanup-CleanerML

Each option will save users several hundred mb to several gigabytes in space, depending on how many drivers they have installed, and the last time they deleted the dirs.

@Chaython Chaython changed the title Add driver Leftovers cleanup Driver Leftovers.xml - Windows Jul 15, 2020
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<cleaner id="Driver Leftovers" os="windows">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the id lowercase and separated by underscore. This helps when running in command line mode, and it's also a convention.

<cleaner id="Driver Leftovers" os="windows">
<label>Driver Leftovers</label>
<description>Deletes staging folders with driver installer data.</description>
<option id="NVIDIA">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the id lowercase. It's a convention.

<option id="Temp">
<label>Temp</label>
<description>Deletes C:\Temp [Used for numerous applications, including RTX Voice]</description>
<action search="walk.top" command="delete" path="C:\Temp"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned, c:\temp\ is used by many applications. They may not be related at all to "driver leftovers." Could you please make this action more specific to "driver leftovers"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only application I had this year was RTX Voice, regardless it's still temporary, usually an installer staging folder

@az0
Copy link
Member

az0 commented Jul 16, 2020

Please see my comments

@Chaython
Copy link
Contributor Author

I believe I made, all requested changes. Sorry for the issues. As per the issue, please see my issue with the "Submitting the cleaner: Submit the cleaner to cleanerml on GitHub as an issue (with a link to a gist) or pull request."

@az0 az0 merged commit 6419d0a into bleachbit:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants