feat(): npm whoami #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuri
reviewed
May 3, 2017
| @@ -106,6 +106,10 @@ export function publishPackage(req: auth.AuthRequest, res: express.Response): vo | |||
| }); | |||
| } | |||
|
|
|||
| export function whoami(req: auth.AuthRequest, res: express.Response): express.Response { | |||
| return res.status(200).json({ "username": res.locals.remote_user.name }); | |||
There was a problem hiding this comment.
how could this work? where do we store remote_user.name in res.locals? not sure but I believe you need to work here with tokens...
There was a problem hiding this comment.
My other way to do that was with a token.
In auth.ts there is a function middleware, where we set remote_user propertie.
There was a problem hiding this comment.
I see, forgot about auth.ts where this is already solved. merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3