Refactoring into submodules #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frapac
reviewed
May 22, 2018
| # TODO This module should be replaced by the package https://github.com/JuliaStochOpt/StochOptInterface.jl | ||
| module StochOptInterface | ||
|
|
||
| using DocStringExtensions |
There was a problem hiding this comment.
Should we continue to use DocStringExtensions?
There was a problem hiding this comment.
No we can get rid of it :)
There was a problem hiding this comment.
What is the reason to stop using it ?
There was a problem hiding this comment.
I am in a minimalistic mood for a few months ...
I tend to believe that the fewer the dependancies, the easier the maintenance is!
src/StructDualDynProg.jl
Outdated
| include("solution.jl") | ||
| # TODO This module should be replaced by the package https://github.com/JuliaStochOpt/StochOptInterface.jl | ||
| include("StochOptInterface/StochOptInterface.jl") | ||
| const SOI = StochOptInterface |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 88.03% 88.31% +0.27%
==========================================
Files 14 17 +3
Lines 869 924 +55
==========================================
+ Hits 765 816 +51
- Misses 104 108 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.