Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact Stopping Criterion #3

Merged
merged 5 commits into from
Feb 26, 2017
Merged

Refact Stopping Criterion #3

merged 5 commits into from
Feb 26, 2017

Conversation

frapac
Copy link
Member

@frapac frapac commented Feb 26, 2017

Add SDDPStats as input of stopping criterion

  • Add new TimeLimit stopping criterion

blegat
blegat reviewed Feb 26, 2017
View reviewed changes
src/stopcrit.jl Outdated
For instance, `TimeLimit(100)` stops after 100s.
"""
type TimeLimit <: AbstractStoppingCriterion
timelimit::Int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be Float64 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed ... I rescope that now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.5% when pulling 06212b7 on refact-stopcrit into a748eee on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.5% when pulling 06212b7 on refact-stopcrit into a748eee on master.

@blegat blegat merged commit db59fce into master Feb 26, 2017
@frapac frapac deleted the refact-stopcrit branch March 7, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frapac @coveralls @blegat