Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cut generator abstraction #8

Merged
merged 3 commits into from
Jun 15, 2017
Merged

Add cut generator abstraction #8

merged 3 commits into from
Jun 15, 2017

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 14, 2017

@odow @frapac @leclere I have added a cut generator abstraction as discussed. It is still rudimentary but the idea is there :-P We should add the RiskMeasure to AvgCutGenerator.

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #8 into master will increase coverage by 4.03%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   84.66%   88.69%   +4.03%     
==========================================
  Files          12       13       +1     
  Lines         841      849       +8     
==========================================
+ Hits          712      753      +41     
+ Misses        129       96      -33
Impacted Files Coverage Δ
src/nlds.jl 89.77% <100%> (+7.07%) ⬆️
src/node.jl 85% <100%> (+20%) ⬆️
src/sddp.jl 90.47% <100%> (+0.19%) ⬆️
src/sddptree.jl 90.9% <100%> (ø) ⬆️
src/comp.jl 100% <100%> (+10%) ⬆️
src/interface.jl 100% <100%> (ø) ⬆️
src/cutgen.jl 86.95% <86.95%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d64882...7bff6e2. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.03%) to 88.693% when pulling 225df98 on cutgen into 8d64882 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+4.03%) to 88.693% when pulling 225df98 on cutgen into 8d64882 on master.

@coveralls
Copy link

coveralls commented Jun 15, 2017

Coverage Status

Coverage increased (+4.03%) to 88.693% when pulling 7bff6e2 on cutgen into 8d64882 on master.

@blegat blegat merged commit c7efe86 into master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants