rename Distribution class to RandomVariable #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinvtran
force-pushed
the
cleanup/rename-distributions
branch
from
65eac98
to
1603de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @ebrevdo's suggestion, we are renaming the
Distributionclass as it is an overloaded term. I propose calling itRandomVariable, which in fact stays truer to its roots. As we add tensor operations we will literally be operating onRandomVariableinstantiations and interpreting them as operations on random variables.Most technically the class conceptually is an XRP from probabilistic programming lingo. But nobody really want to use that jargon as part of the API (I think Noah moved recently as well), in the same way I personally do not want to start using
thunkeverywhere to replacemodel.(We should also merge this now, before merging tomorrow morning's new website release #149.)