Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline JS script #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hgtonight
Copy link

Gdn_Controller provides an InformMessage() method.

Gdn_Controller provides an `InformMessage()` method.
@bleistivt
Copy link
Owner

That would make it nice and short, but it's not really the same.
The intention is for the message to pop up only if a users focuses the comment form (so it draws immediate attention). If the message is always there, people get used to it and may ignore it.

When 2.2 is released changing this to use Head->AddScript() will be cleaner.

@hgtonight
Copy link
Author

Oh wow.

I feel like an idiot. I didn't even notice the on focus.

I still have an idea that would make it "cleaner". Will post to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants