Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r2.New() should set r.URL on the returned value #143

Open
dhermes opened this issue Nov 21, 2019 · 1 comment
Open

r2.New() should set r.URL on the returned value #143

dhermes opened this issue Nov 21, 2019 · 1 comment
Labels
v3.x.y Version 3 series

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 21, 2019

See: r2.New() puts the parsed URL into r.Request but OptHost() only touches r.URL
@dhermes
Copy link
Contributor Author

dhermes commented Nov 21, 2019

(I may have this all confused because of the intricacies of struct embedding)

@dhermes dhermes mentioned this issue Dec 12, 2019
Open
@dhermes dhermes added the v3.x.y Version 3 series label Dec 12, 2019
This was referenced Feb 1, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3.x.y Version 3 series
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhermes