Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Ask permission while receiving a file #101

Open
blenderskool opened this issue Dec 14, 2020 · 1 comment
Open

[RFC] Ask permission while receiving a file #101

blenderskool opened this issue Dec 14, 2020 · 1 comment
Labels
feature New feature or request

Comments

@blenderskool
Copy link
Owner

When a file is sent in a room, other peers in the room must get an option to accept/ignore the file receive request initially. If they ignore the file, files would only be transferred to people who accepted the request.

Not sure if it makes sense as Blaze already has rooms in place which would encourage people interested in the files to join a common room and then share the file. If we go with implementing this, few things need to be chalked out:

  • How file download acceptance is managed in WebTorrent and WebSocket.
  • In group sharing with WebSockets, files are broadcasted to all peers at once. If a peer does not accept/decline the file request, the other peers(who accepted the request) may end up waiting. A timer may be added when the request is shown which would by default ignore the request after the timer runs out. Would need some inputs here.
@blenderskool blenderskool added the feature New feature or request label Dec 14, 2020
@ShadowGaming100
Copy link

Good feature, wish soon this will be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants