Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package, add hut4 rules file #1

Merged
merged 1 commit into from
Feb 29, 2016
Merged

fix package, add hut4 rules file #1

merged 1 commit into from
Feb 29, 2016

Conversation

codegoblin
Copy link

this silos the hut4 rules into a single file

@cdidyk
Copy link

cdidyk commented Jan 18, 2016

I'm not sure what came of the discussion on slack, but it sounds like it makes more sense to leave the bletchley-level linter/styles "pristine" (instead of forcing hut4's modifications on it) and keeping hut-specific modifications separate. I'm guessing that would happen through hut-specific packages?

Also, what do you think about describing the process for modifying hut-specific (and bletchley-wide) style guides in the wiki?

@cdidyk
Copy link

cdidyk commented Jan 18, 2016

Oh, I forgot to say that I +1 this PR. Even if the answers to my questions above change some things, I don't think those changes would be a big deal nor should they stand in the way of us getting going customizing this guide.

@codegoblin
Copy link
Author

You don't have to build a new package, you just need to stipulate extend: bletchley/hut4 ... if you just want all the top-level, non-hut rules you would stipulate extend: bletchley in the .eslintrc

I totally agree with the readme expansion. Maybe I'll get some time to do that today.

@cdidyk
Copy link

cdidyk commented Jan 18, 2016

Groovy

riniculous added a commit that referenced this pull request Feb 29, 2016
fix package, add hut4 rules file
@riniculous riniculous merged commit e381f5e into master Feb 29, 2016
@riniculous riniculous deleted the hut4 branch February 29, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants