Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder always uses zap v11 #1406

Closed
mschoch opened this issue May 26, 2020 · 3 comments · Fixed by #1407
Closed

Builder always uses zap v11 #1406

mschoch opened this issue May 26, 2020 · 3 comments · Fixed by #1407

Comments

@mschoch
Copy link
Member

mschoch commented May 26, 2020

No matter what configuration you pass in, zap v11 is used due to a bug:

https://github.com/blevesearch/bleve/blob/master/index/scorch/builder.go#L109-L111

@mschoch
Copy link
Member Author

mschoch commented May 26, 2020

cc @tylerkovacs

@mschoch
Copy link
Member Author

mschoch commented May 26, 2020

Note: if you happen to parse your config from JSON, it still may not work until this PR is merged: #1401

@mschoch
Copy link
Member Author

mschoch commented May 26, 2020

With the bug fixes, plus the new versions of zap, I see the following sizes using the IndexBuilder with the 1 million wikipedia articles (no stored fields, no term vectors)

9083488	bleve-builder-scorch-zapv11-mil.bleve
3127756	bleve-builder-scorch-zapv12-mil.bleve
3100816	bleve-builder-scorch-zapv13-mil.bleve
3056260	bleve-builder-scorch-zapv14-mil.bleve

Essentially everything after zap v11 is just a minor improvement (for this index mapping).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant