improve scorch config parsing of forced zap version #1401
Conversation
previous version did not correctly handle integer values stored in a float64 due to JSON parsing
index/scorch/scorch.go
Outdated
|
|
||
| return forcedSegmentType, uint32(forcedSegmentVersion), nil | ||
| forcedSegmentType, ok2 := config["forceSegmentType"].(string) |
There was a problem hiding this comment.
Now that there's no "ok" anymore, "ok2" should be the new "ok" :-D
| } | ||
| forcedSegmentVersion, err := parseToInteger(config["forceSegmentVersion"]) | ||
| if err != nil { | ||
| return "", 0, nil |
There was a problem hiding this comment.
in case of err, its returning nil?
There was a problem hiding this comment.
Yes, because error in this case just means that it was not int or float64, in which case we do not proceed to process the settings (which I believe is consistent with what we did before).
There was a problem hiding this comment.
I am not very sure of this. Giving some hints about the incorrect format looks cleaner to me than not giving any clues to the user of what is going wrong.
Also, unable to comprehend the importance of maintaining consistency with what we did before for a small period of time between v11 - v12/13..
There was a problem hiding this comment.
I'm not arguing for consistency, I'm simply saying I'm not changing the behavior (other than adding support for float64). If you'd like to improve the error handling, maybe you should create your own PR?
code review feedback
|
Just wasted half a day yesterday testing, because this PR hasn't been merged, bleve-blast wasn't using my forceSegmentVersion configuration. |
previous version did not correctly handle integer
values stored in a float64 due to JSON parsing