Initialise the root snapshot's DecRef errs with Close() #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the scorch's Close call, the root snapshot's DecRef return errs were ignored. Fixing that to bubble up the errors so that the higher levels may listen and act on it.
steveyen
requested changes
Mar 16, 2020
There was a problem hiding this comment.
Hi -- I'm thinking using the "err2" pattern here might be better, in that this current proposal is blowing away the err from the s.rootBolt.Close()?
And, in another situation if err was non-nil from the Close(), then this proposal might inadvertently set the err to nil during a successful DecRef()?
| @@ -263,7 +263,7 @@ func (s *Scorch) Close() (err error) { | |||
| err = s.rootBolt.Close() | |||
There was a problem hiding this comment.
This err gets overwritten. Is that ok? Should we just return here if this err isn't nil perhaps?
There was a problem hiding this comment.
i didn't see the above initialisation.. oops..
steveyen
approved these changes
Mar 17, 2020
abhinavdangeti
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the scorch's Close call, the root snapshot's
DecRef return errs are ignored. Fixing that to bubble up
the errors so that the higher levels may listen and
act on it.