MatchOperator should be that type instead of int #1410
Conversation
Right now `MatchOperator` constants are ints and when you're trying to assign them to a variable you get an int. If you try to use those variables as operator you get the following error: ``` cannot use operator (type int) as type MatchQueryOperator in argument to q.SetOperator ``` So, to fix this problem we just need to create `MatchOperator` constants
|
I'm fine with the change, but technically it does break the API since it changes the type of an exported identifier. It is inside a sub-package, so probably not as big a deal, but still seems like something that should be a 2.0 change, since it can be worked around anyway. |
|
@mschoch Yes, I thought that but didn't know if you're following semver. I agree with leaving that change to version 2.x given that is a breaking change. Hope it helps :) |
|
Read about release of version 2, would be these changes included? |
|
I would be OK adding this to v2. It's relatively small, but since its a breaking change, this is a good opportunity. Thoughts @abhinavdangeti @sreekanth-cb? |
|
Ya good time to merge I think. |
|
This has been merged to the 2.x branch, and I've updated the documentation to mention it. Thanks for the contribution and the reminder ping @ethervoid |
|
@mschoch thank you for taking care :) |
* refactor to remove circular deps * reduce index and segment API surface area * update Advanced() method (#1509) * relocate store pkg inside upsidedown (#1510) * remove Advanced() method from scorch (#1511) * remove use of dump methods from index reader (#1516) * remove remaining blevex imports (#1520) * update analysis.TokenFrequency to use options (#1522) * switch default index to scorch with latest zap (#1528) * MatchOperator should be that type instead of int (#1410) Co-authored-by: Sreekanth Sivasankaran <sreekanth.sivasankaran@couchbase.com> Co-authored-by: Mario de Frutos Dieguez <mario@defrutos.org>
Right now
MatchOperatorconstants are ints and when you're trying toassign them to a variable you get an int. If you try to use those
variables as an operator you get the following error:
So, to fix this problem we just need to create
MatchOperatorconstants