MB-60207 fix facets merge #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshaad7
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
metonymic-smokey
changed the title
moshaad7
force-pushed
the
fix_fascet_merge
branch
from
6f3db19
to
8cbb3a6
Compare
+ Customer Marshal logic of FacetResult can lead to FacetResult.Terms being nil. + (*FacetResult)Merge now handle the above^ case. + added similar nil case handler for NumericRanges and DateRanges
moshaad7
force-pushed
the
fix_fascet_merge
branch
from
8cbb3a6
to
129819c
Compare
metonymic-smokey
approved these changes
Dec 21, 2023
Thejas-bhat
approved these changes
Dec 21, 2023
moshaad7
added a commit
that referenced
this pull request
Dec 21, 2023
moshaad7
added a commit
that referenced
this pull request
Dec 21, 2023
abhinavdangeti
added a commit
that referenced
this pull request
Jan 2, 2024
|\ | * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946) | * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898) | * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905) | * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897)
abhinavdangeti
added a commit
that referenced
this pull request
Feb 13, 2024
``` * 5c7445c Abhinav Dangeti | Fix merge conflict * a0cb65a Abhinav Dangeti | Merge remote-tracking branch 'origin/master' into 7.6-couchbase |\ | * 5f1f45a Sergio Vera | Fixed spanish accents normalization (#1957) | * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946) | * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898) | * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905) | * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897) * | 8b9206a Abhi Dangeti | MB-60739: Upgrade go-faiss & zapx/v16 (#1985) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.