MB-54131: Geoshape query decode optimization #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added buffer pool pointer to polygon - Added parent polygon pointer to loop - Added decoder function to select, populate and return a pointer to the buffer from a pool of buffers - Updated loop decode function to handle chunks of data being read - Updated polygon decode function to pass on the buffer pool to the loops - Updated extractShapesFromBytes and FilterGeoShapesOnRelation to include the buffer pool in its parameters
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat and
metonymic-smokey
abhinavdangeti
requested changes
Aug 21, 2023
- Changed buffer pool from pointer to slice - Removed randomly formatted comments
Likith101
force-pushed
the
master
branch
2 times, most recently
from
167dcc2
to
d279cac
Compare
+ add .gitignore
moshaad7
reviewed
Aug 23, 2023
moshaad7
reviewed
Aug 23, 2023
moshaad7
reviewed
Aug 23, 2023
- Added a buffer pool struct - Increased size of the maximum buffer to 24KB - Added better comments
- Minor formatting fixes - Reusing buffers instead of creating everytime
Thejas-bhat
reviewed
Aug 29, 2023
- Better comments - Removed some magic numbers
- Changed buffer pool implementation to give the smallest buffer that fits the data completely - Changed decoder implementation to allow buffer sizes bigger than number of bytes needed
- Renamed some constants
moshaad7
reviewed
Aug 30, 2023
| if size >= len(buf) { | ||
| _, d.err = io.ReadFull(d.r, buf) | ||
| return len(buf) | ||
| } else { |
There was a problem hiding this comment.
since we are using return statement inside "if" block, thus we don't need an else block.
if size >= len(buf) {
_, d.err = io.ReadFull(d.r, buf)
return len(buf)
}
_, d.err = io.ReadFull(d.r, buf[0:size])
return size
- Added benchmark for loop decode
| @@ -24,6 +25,9 @@ import ( | |||
| "github.com/golang/geo/s1" | |||
| ) | |||
|
|
|||
| const SizeOfFloat = 8 | |||
There was a problem hiding this comment.
Should perhaps use reflect to detect size of float64. Will add separately.
abhinavdangeti
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
- blevesearch/bleve#1864