Returning bytesRead per query as part of searchResult #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey and
moshaad7
read.go
Outdated
| @@ -22,7 +22,7 @@ func (s *SegmentBase) getDocStoredMetaAndCompressed(docNum uint64) ([]byte, []by | |||
| meta := s.mem[storedOffset+n : storedOffset+n+metaLen] | |||
| data := s.mem[storedOffset+n+metaLen : storedOffset+n+metaLen+dataLen] | |||
|
|
|||
| s.incrementBytesRead(metaLen + dataLen) | |||
| // s.incrementBytesRead(metaLen + dataLen) | |||
There was a problem hiding this comment.
Yeah resolving them, my bad.
read.go
Outdated
| @@ -41,7 +41,7 @@ func (s *SegmentBase) getDocStoredOffsets(docNum uint64) ( | |||
| dataLen, read := binary.Uvarint(s.mem[storedOffset+n : storedOffset+n+binary.MaxVarintLen64]) | |||
| n += uint64(read) | |||
|
|
|||
| s.incrementBytesRead(n) | |||
| // s.incrementBytesRead(n) | |||
|
@Thejas-bhat Use bleve_index_api@v1.0.5 and scorch_segment_api@v2.1.4. |
by avoid the double counting of stuff - fixing the double counting of a segment's loading portion of bytes read
Thejas-bhat
force-pushed
the
bytesReadPerQuery
branch
from
61508b9
to
891f48f
Compare
abhinavdangeti
requested changes
Nov 8, 2022
|
Yeah, fixed the implementation now. |
This was referenced Nov 9, 2022
abhinavdangeti
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.