Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-61029: Caching Vec To DocID Map #231

Merged
merged 6 commits into from
Apr 18, 2024
Merged

MB-61029: Caching Vec To DocID Map #231

merged 6 commits into from
Apr 18, 2024

Commits on Apr 16, 2024

  1. MB-61029: Adding vecToDocID map to the vector index cache 

     - Generalised some of the cache function names to be inclusive of the map
 - Added the map to the cache which will behave the same as the index
 - Except bitmap logic is not part of the cache and the vecs excluded is
calculated outside of the map
    @Likith101
    Likith101 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ba89580 View commit details
    Browse the repository at this point in the history

  2. Proper lock context fixes + naming + optimizations

    @abhinavdangeti
    abhinavdangeti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f43df2c View commit details
    Browse the repository at this point in the history

  3. Code organizing

    @abhinavdangeti
    abhinavdangeti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    11a2ad6 View commit details
    Browse the repository at this point in the history

  4. Consistent cache lookups

    @abhinavdangeti
    abhinavdangeti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7913386 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Function to Calculate VecIDsToExclude

    @Likith101
    Likith101 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5e3882f View commit details
    Browse the repository at this point in the history

  2. Consistent calls to getInvalidVecs(..)* -> getVecIDsToExclude(..) 

    + Increase ref counts within locking (read or write) to avoid any
  possibility of raciness. This includes invoking cacheEntry.load().
+ Also refactors getInvalidVecs to getVecIDsToExclude.
    @abhinavdangeti
    abhinavdangeti committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    42fb9dd View commit details
    Browse the repository at this point in the history