Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling reset() with a running timer crashes. #33

Closed
lisdude opened this issue May 25, 2020 · 1 comment
Closed

Calling reset() with a running timer crashes. #33

lisdude opened this issue May 25, 2020 · 1 comment
Labels
bug Something isn't working
Projects

Comments

@lisdude
Copy link
Contributor

lisdude commented May 25, 2020

Describe the bug
If you call the reset() function from Lua after a timer has been added, the client will crash the next time the timer runs.

To Reproduce

  1. crashtest.lua with the content: blight:add_timer(10, 0, function() blight:output("hi"); end);
  2. reset.lua with the content: blight:reset();
  3. Connect somewhere
  4. /load crashtest.lua
  5. /load reset.lua

In about 8 seconds, the client will crash.

What terminal are you using?
Kitty

@lisdude lisdude added the bug Something isn't working label May 25, 2020
@LiquidityC
Copy link
Member

I thought this might be a problem. Reset should drop all timers as well as the lua state.

@LiquidityC LiquidityC added this to To do in Release 0.1 via automation May 25, 2020
Release 0.1 automation moved this from To do to Done May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Release 0.1
  
Done
Development

No branches or pull requests

2 participants