Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first move from a simple doc to a dev portal #16

Merged
merged 16 commits into from
Jun 20, 2022
Merged

first move from a simple doc to a dev portal #16

merged 16 commits into from
Jun 20, 2022

Conversation

nweldev
Copy link

@nweldev nweldev commented Jun 17, 2022

Update for https://github.com/blindnet-io/communication-management/issues/142

Note

This PR introduce a new brand color for blindnet.dev, close to "Lilliputian Lime": 88dc4c.

It is a complementary colour to the (close to) "Fandango Pink" colour we already use for the blindnet.io and Privateform brands, dc4c87.

Both can work as a triadic with a colour close to "Andrea Blue", 4c87dc, which could be later used as a secondary colour on both websites, or for another brand.

triadic colors

@nweldev nweldev changed the title Prep summer first move from a simple doc to a dev portal Jun 19, 2022
@nweldev
Copy link
Author

nweldev commented Jun 19, 2022

Warning

The new texts on the home page require special attention during the review.
@milstan I added you as a review for this part only (don't bother with the rest).

add buttons, additionnal banner, and reorg the page
Use the complementary color to the one commonly used for the blindnet
and privateform brands (#dc4c87 on blindnet.io) with the default dark
theme to make the content more readable and impactful, and to make the
two brands work better together if needed.

For the light theme, this color has been shifted to a darker tone using
a palette generator and try-and-error on https://docusaurus.io/docs/styling-layout
in order to ensure a good enough contrast for readability.

Finally, some wordings has also been updated for consistency with
previous changes and better impact.
add an Introduction page (based on How It Works > Introduction) and
reorganise sections

close #11
add dev.to and update copyright and other menu items
resize the blog banner image and better organize and
dimension the index illustrations
@nweldev nweldev marked this pull request as ready for review June 19, 2022 16:07
Copy link
Member

@filipblnt filipblnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment, the green colour of the links is not so visible in the light theme, check it out. Maybe we'll need to make it more stronger. In the dark mode it works quite well.

src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
blog/2022-06-16-hello-world.md Outdated Show resolved Hide resolved
blog/2022-06-16-hello-world.md Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
docs/quickstart.mdx Outdated Show resolved Hide resolved
@filiprd filiprd removed their request for review June 20, 2022 09:09
Copy link
Member

@milstan milstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noelmace I am not sure what you are reffering to when you say "new texts", but everything I see here looks OK to me.

README.md Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
@nweldev
Copy link
Author

nweldev commented Jun 20, 2022

@filipblnt What do you mean by "not visible"?

I see different possible issues:

  1. links not "standing out" enough
  2. contrast issue on gray backgrounds
    • for example in the footer
      image

As indicated in 5ed1da8, I used https://docusaurus.io/docs/styling-layout to find the right colours. But I forgot about (2), as Docusaurus is kind of a mess on this. I'll fix it right away.

For (1.2), I can't see what we should do here. IMHO, this is OK. Shifting to a lighter colour (like 108a03 for example) would break the accessibility. We could use a bold or underlined font, but I don't think it would be a very good solution. Any suggestion?

@nweldev nweldev force-pushed the prep-summer branch 3 times, most recently from 1aec8b1 to dd53e3f Compare June 20, 2022 09:56
@nweldev nweldev requested a review from filipblnt June 20, 2022 09:57
@nweldev
Copy link
Author

nweldev commented Jun 20, 2022

@milstan thx for the review. FYI, I was reffering to the new sections in the home page.

image

docs/how_it_works/introduction.mdx Outdated Show resolved Hide resolved
docusaurus.config.js Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
nweldev pushed a commit that referenced this pull request Jun 20, 2022
see PR review by Filip, Milan and Marko

#16
nweldev pushed a commit that referenced this pull request Jun 20, 2022
see PR review by Filip, Milan and Marko

#16
nweldev pushed a commit that referenced this pull request Jun 20, 2022
see PR review by Filip, Milan and Marko

#16
see PR review by Filip, Milan and Marko

#16
@nweldev
Copy link
Author

nweldev commented Jun 20, 2022

@m4rk055 except if @filipblnt has any other feedback, you can now merge and release this in production.

@nweldev nweldev marked this pull request as draft June 20, 2022 15:05
@nweldev nweldev marked this pull request as ready for review June 20, 2022 15:08
@filipblnt
Copy link
Member

filipblnt commented Jun 20, 2022

@noelmace #16 (comment)

I meant 1, I personally think that links in 1.2 are not standing our enough.

@filipblnt filipblnt merged commit 7e2f539 into main Jun 20, 2022
@nweldev
Copy link
Author

nweldev commented Jun 20, 2022

Thx for the merge @filipblnt. I added a new issue #17 to remember me to investigate your feedback on links' colour.

@nweldev nweldev deleted the prep-summer branch September 5, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants