-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first move from a simple doc to a dev portal #16
Conversation
|
add buttons, additionnal banner, and reorg the page
Use the complementary color to the one commonly used for the blindnet and privateform brands (#dc4c87 on blindnet.io) with the default dark theme to make the content more readable and impactful, and to make the two brands work better together if needed. For the light theme, this color has been shifted to a darker tone using a palette generator and try-and-error on https://docusaurus.io/docs/styling-layout in order to ensure a good enough contrast for readability. Finally, some wordings has also been updated for consistency with previous changes and better impact.
add an Introduction page (based on How It Works > Introduction) and reorganise sections close #11
add dev.to and update copyright and other menu items
resize the blog banner image and better organize and dimension the index illustrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment, the green colour of the links is not so visible in the light theme, check it out. Maybe we'll need to make it more stronger. In the dark mode it works quite well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noelmace I am not sure what you are reffering to when you say "new texts", but everything I see here looks OK to me.
@filipblnt What do you mean by "not visible"? I see different possible issues:
As indicated in 5ed1da8, I used https://docusaurus.io/docs/styling-layout to find the right colours. But I forgot about (2), as Docusaurus is kind of a mess on this. I'll fix it right away. For (1.2), I can't see what we should do here. IMHO, this is OK. Shifting to a lighter colour (like 108a03 for example) would break the accessibility. We could use a bold or underlined font, but I don't think it would be a very good solution. Any suggestion? |
1aec8b1
to
dd53e3f
Compare
@milstan thx for the review. FYI, I was reffering to the new sections in the home page. |
see PR review by Filip, Milan and Marko #16
see PR review by Filip, Milan and Marko #16
see PR review by Filip, Milan and Marko #16
see PR review by Filip, Milan and Marko #16
@m4rk055 except if @filipblnt has any other feedback, you can now merge and release this in production. |
I meant 1, I personally think that links in 1.2 are not standing our enough. |
Thx for the merge @filipblnt. I added a new issue #17 to remember me to investigate your feedback on links' colour. |
Update for https://github.com/blindnet-io/communication-management/issues/142