Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Commit

Permalink
Move TODOs to github issue
Browse files Browse the repository at this point in the history
  • Loading branch information
blindpirate committed Jan 13, 2017
1 parent 479a635 commit c8498d5
Show file tree
Hide file tree
Showing 13 changed files with 0 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public void build() {
public void installDependency(ResolvedDependency dependency) {
File targetDir = ensureProjectGopathWritable().resolve(dependency.getName()).toFile();
forceMkdir(targetDir);
// TODO it is disputable whether clearing target directory should be done
clearDirectory(targetDir);
dependency.installTo(targetDir);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public Path getGlobalCachePath(String packagePath) {
return gradleHome.resolve(GOPATH_CACHE_PATH).resolve(packagePath);
}

// TODO in case of package a/b/c and package a/b accessed concurrently, we should lock its root package
@Override
public synchronized <T> T runWithGlobalCacheLock(GolangDependency dependency, Callable<T> callable)
throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ private VcsType extractVcs(String notation) {
private String extractPackagePath(String notation) {
for (int i = 0; i < notation.length(); ++i) {
char c = notation.charAt(i);
// TODO not accurate
if (c == '#' || c == '@') {
return notation.substring(0, i);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import static java.lang.annotation.ElementType.PARAMETER;
import static java.lang.annotation.RetentionPolicy.RUNTIME;

// TODO cache decorator for factories
@Singleton
public class DefaultDependencyVisitor implements DependencyVisitor {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*
* @see <a href="https://github.com/robfig/glock">glock</a>
*/
// TODO currently cmd dependencies are ignored
public class GlockfileParser {
public List<Map<String, Object>> parse(File file) {
return IOUtils.getLines(file)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
*
* @see <a href="https://github.com/gpmgo/docs/blob/master/en-US/gopmfile.md" >.gopmfile</a>
*/
// TODO
// FileBasedConfig in JGit can't parse this since it sees the key 'github/x/y' as invalid key (unfortunately, it is)
// current parser is simple, we should use ANTLR to do the parsing.
public class GopmfileParser {
private static final String DEPS_SECTION = "[deps]";
private static final String BRANCH_KEYWORD = "branch:";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
* @see <a href="https://github.com/rancher/trash/blob/master/vendor.conf">vendor.conf</a>
*/

// TODO
// # exclude
// -golang.org/x/net/context
// https://github.com/ethereum/go-ethereum/blob/master/vendor.conf
public class VendorDotConfParser {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ private Optional<GolangPackage> fetchViaWeb(String packagePath, String url) {
Assert.isTrue(!elements.isEmpty(), "Missing meta in response of " + url);

String content = elements.get(0).attr("content");
// TODO According to https://golang.org/cmd/go/#hdr-Remote_import_paths
// we should verify it
//String importPath = matcher.group(1);
LOGGER.info("Meta tag of url {} is:{}", url, content);
return Optional.of(buildPackageInfo(packagePath, content));
} catch (IOException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import static com.github.blindpirate.gogradle.task.GolangTaskContainer.RESOLVE_TASK_NAME;

// TODO old dependencies should be deleted before installation
public class InstallDependenciesTask extends AbstractGolangTask {
@Inject
private BuildManager buildManager;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ protected RevCommit determineVersion(Repository repository, NotationDependency d
}

// use HEAD of master branch
// TODO the default branch may not be master
return gitAccessor.headCommitOfBranch(repository, DEFAULT_BRANCH).get();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.github.blindpirate.gogradle.core.dependency.AbstractNotationDependency;
import com.github.blindpirate.gogradle.core.dependency.resolve.DependencyResolver;

// TODO what about branch?
public class GitNotationDependency extends AbstractNotationDependency {

public static final String NEWEST_COMMIT = "NEWEST_COMMIT";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import static com.github.blindpirate.gogradle.util.ReflectionUtils.setFieldSafel
* <li>5.Clean up temp directories whenever necessary.</li>
* <ul>
*/
// TODO: ignore @AccessWeb when offline
class GogradleRunner extends BlockJUnit4ClassRunner {

private static final String PROJECT_FEILD = 'project'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ class GitDependencyManagerTest extends MockInjectorSupport {
when(notationDependency.getPackage()).thenReturn(thePackage)
}

// TODO we need an integration test to test all
// both GitDependencyDependencyManager and GitAccessor

@Test
void 'nonexistent repo should be cloned when url specified'() {
// given:
Expand Down

0 comments on commit c8498d5

Please sign in to comment.