-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Minitest with RSpec: bigbluebutton_api_controller specs (1) #911
Replace Minitest with RSpec: bigbluebutton_api_controller specs (1) #911
Conversation
ecf1cf0
to
5edb384
Compare
2802004
to
c7f416c
Compare
6ba1bec
to
edab51c
Compare
845a25f
to
58e0dc7
Compare
e90aeb6
to
ed794a6
Compare
@@ -65,6 +69,4 @@ | |||
# arbitrary gems may also be filtered via: | |||
# config.filter_gems_from_backtrace("gem name") | |||
config.include FactoryBot::Syntax::Methods | |||
|
|||
config.include RSpec::RedisHelper, redis: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon reviewing, I support using fakeredis
for our testing environment
fakeredis
ensures that the tests are isolated from each other. Hence, redis_helper
was removed as it seems it was used strictly to configure a redis database for the test environment.
However, there might be complex Redis usage implementation in the future that makes fakeredis
not suitable.
Everything seems to be working as it should on our testing environment for now.
ed794a6
to
b34bf7b
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
redis_helper
bbb_api_controller
specsServer
FactoryMeeting
FactoryDesign considerations
redis_helper
file as we will be usingfakeredis
and we don't need to configure a redis database for the test environmentNotes
override_create_params
adds the new params at the end of the uri, anddefault_create_params
adds them at the beginning of the uri. Not following the order will return a different checksum value.