Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure bumpversion #10

Merged
merged 12 commits into from Apr 13, 2019
Merged

Configure bumpversion #10

merged 12 commits into from Apr 13, 2019

Conversation

matyama
Copy link
Contributor

@matyama matyama commented Apr 12, 2019

Description

  • Adds twine and bumpversion to make setup-dev
  • Adds bumpversion config
  • Adds extra badges to README
  • Configures PyPI deployment from Travis CI on master branch tag

Test plan

@matyama matyama self-assigned this Apr 12, 2019
@matyama matyama added the enhancement New feature or request label Apr 12, 2019
@matyama
Copy link
Contributor Author

matyama commented Apr 12, 2019

We probably want to squash this one after review ;)

This was referenced Apr 12, 2019
Copy link
Contributor

@martinbabka martinbabka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe twine and bumpversion could be added to develop reqs. But this is a matter of choice ;). Well done, sir!

@matyama
Copy link
Contributor Author

matyama commented Apr 13, 2019

Maybe twine and bumpversion could be added to develop reqs. But this is a matter of choice ;). Well done, sir!

@martinbabka Good point, I'll leave it as it is for now. I do think that we'll have to re-visit and cleanup setup.py though. On the other hand, neither of them is required to run make release-check to move it to test requirements...but maybe extras_require, we'll see ;)

@matyama matyama merged commit 527736d into master Apr 13, 2019
@matyama matyama deleted the configure-bumpversion branch April 13, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants