Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itertoolz: ordering-related functions and ADT package #32

Merged
merged 5 commits into from
Aug 23, 2019

Conversation

matyama
Copy link
Contributor

@matyama matyama commented Aug 14, 2019

Description

  • Adds new package adt for Abstract Data Types (ADTs)
    • implements mutable iterator MutIter which can be both consumed and appended to
    • example usage: as an accumulator for reduceby and similar
  • Adds two new functions to itertoolz
    • positions - collects positions of non-unique items in a sequence
    • order_by - orders (and fills missing) items in order given by a sequence of keys

Test plan

Passing release check and complete coverage.

@matyama matyama added the enhancement New feature or request label Aug 14, 2019
@matyama matyama self-assigned this Aug 14, 2019
@matyama
Copy link
Contributor Author

matyama commented Aug 14, 2019

Two comments:

  1. There seems to be a lint issue for Python 3.7 (see Travis), I'll resolve it.
  2. If you have better names for newly added functions, let me know ;)

@matyama
Copy link
Contributor Author

matyama commented Aug 14, 2019

Ad. first issue - it turns out, that is known pylint bug, I'll leave it silenced for now (I've fixed the other error)

@matyama matyama merged commit 0860ac3 into master Aug 23, 2019
@matyama matyama deleted the itertoolz-ordering branch August 23, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants