#24 add docs, notes and function test for skypeforbusiness connector

blindzero · May 14, 2020 · bc08cd6 · bc08cd6
1 parent 3e2e19a
commit bc08cd6
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 1 deletion.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -16,6 +16,8 @@ Powershell module to connect to all MS365 services and install required packages
 
 ### New Features
 
+- [#24](https://github.com/blindzero/Connect-MS365/issues/24) added Skype for Business option
+
 ### Changes
 
 - re-enabling code notary git signature check

diff --git a/docs/01-INSTALLATION.md b/docs/01-INSTALLATION.md
@@ -27,7 +27,7 @@ The following requirements must be installed _prior_ installation of Connect-MS3
 
 ### Installation
 
-#### Install by Install-Module from PowerShellGallery (NuGet)
+#### Install by Install-Module from PowerShellGallery
 
 Installation from online [PowerShellGallery](https://powershellgallery.com) by using PowerShellGet function `Install-Module`.
 

diff --git a/docs/02-USAGE.md b/docs/02-USAGE.md
@@ -56,6 +56,13 @@ The service you want to connect is selected by `-Service` parameter, followed by
 
   See the [CmdLet reference](https://docs.microsoft.com/de-de/powershell/module/?view=azps-3.8.0) for all available commands.
 
+* __S4B__ - Microsoft Skype for Business (credits to [RasmusAaen](https://github.com/RasmusAaen))
+
+  Uses SkypeOnlineConnector module to connect to Microsoft Skype for Busines.
+  As SkypeOnlineConnector is not published on powershellgallery.com it must be [installed manually](https://www.microsoft.com/en-us/download/details.aspx?id=39366) if not available.
+
+  See the [CmdLet reference](https://docs.microsoft.com/en-us/powershell/module/skype/?view=skype-ps) for all available commands.
+
 ### Multi Factor Authentication (MFA)
 
 By version 1.1.0 modern authentication usage is default, incl. MFA functionality.

diff --git a/docs/03-CONTRIBUTE.md b/docs/03-CONTRIBUTE.md
@@ -2,3 +2,7 @@
 
 ## 03-CONTRIBUTE
 
+### Contributors
+
+[blindzero](https://github.com/blindzero)
+[RasmusAaen](https://github.com/RasmusAaen)
diff --git a/docs/Connect-MS365.md b/docs/Connect-MS365.md
@@ -34,6 +34,7 @@ Supports connection handling for
 - Security and Compliance Center (SCC)
 - Azure ActiveDirectory (AAD) v2
 - Azure Platform (AZ)
+- Skype for Business Online service (S4B)
 
 ## EXAMPLES
 
@@ -79,6 +80,13 @@ Description: Connect to Microsoft Azure platform
 
 Connect-MS365 -Service AZ
 
+### EXAMPLE 7
+```
+Description: Connect to Microsoft Skype for Business Online service
+```
+
+Connect-MS365 -Service S4B
+
 ## PARAMETERS
 
 ### -Service

diff --git a/tests/Connect-MS365.Tests.ps1 b/tests/Connect-MS365.Tests.ps1
@@ -59,6 +59,7 @@ Describe "Function Tests" -Tags ('Unit') {
         { Get-Command Connect-SCC } | Should Throw
         { Get-Command Connect-AAD } | Should Throw
         { Get-Command Connect-Az } | Should Throw
+        { Get-Command Connect-S4B } | Should Throw
         { Get-Command Test-MS365Module } | Should Throw
         { Get-Command Install-MS365Module } | Should Throw
         { Get-Command Set-WindowTitle } | Should Throw
@@ -105,6 +106,12 @@ Describe "Function Tests" -Tags ('Unit') {
         }
         Context "Function Connect-AZ.ps1 Tests" {
         }
+        Context "Function Connect-S4B.ps1 Tests" {
+            It "Has Parameter -Credential" {
+                Get-Command Connect-S4B | Should -HaveParameter Credential -Type PSCredential
+                Get-Command Connect-S4B | Should -HaveParameter Credential -Not -Mandatory
+            }
+        }
         Context "Function Set-WindowTitle.ps1 Tests" {
             It "Has Parameter -Service" {
                 Get-Command Set-WindowTitle | Should -HaveParameter Service -Type String -Mandatory