Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.0.0 rc release #9

Merged
merged 24 commits into from
Jul 30, 2024
Merged

V1.0.0 rc release #9

merged 24 commits into from
Jul 30, 2024

Conversation

blink-zero
Copy link
Owner

Added

  • History search for VM status DB value
  • Password visibility toggle for post-deployment change password
  • Support for Update OS, Change Password, and Increase disk size operations
  • Playbook edit functionality
  • Confirmation for VM restart in history.html
  • Paramiko v3.4.0 dependency
  • Image human name to History model

Changed

  • Overall theme overhaul
  • Updated various templates and settings tabs to match overall theme
  • Updated VM images form and user.html CSS to match theme
  • Increased height of Playbook View modal and Edit Playbook modal
  • Widened ansible log modal
  • Modified links on home dashboard to filter completed, running, and other statuses
  • Updated VM history DB model and details modal
  • Updated README.md key features area

Fixed

  • Uploading image bug when uploading with suffix brackets on zip files
  • Server Error 500 on admin user deletion, now showing flash message instead

Removed

  • Kali 2024.1 Image (moved to community repository)
  • Unnecessary comments in code

@blink-zero
Overall Theme overhaul + new features and bug fixes
96e2998
@blink-zero
update README.md
e3c15cf
@blink-zero
cleaned users_tab.html up
31d19de
@blink-zero
added playbook edit functionality
94b0930
@blink-zero
Added confirmation for vm restart in history.html
729906f
@blink-zero
Updated vm images form css to match theme
df71def
@blink-zero
Updated user.html css form to match theme
3d983eb
@blink-zero
updated vm history db model, updated vm history details modal
b4beb5d
@blink-zero
added image human name to History model
5642785
@blink-zero
Added paramiko v3.4.0
8455fe9
@blink-zero
Added support for Updat OS, Change Password and Increase disk size
88a16a4
@blink-zero
Fixed width on ansible log modal to be wider
0c23ec3
@blink-zero
Changed Deployaroo Version to 1.0.0RC
142bcf7
@blink-zero
Deleted unessessary comments, Widened ansible log modal
ea06351
@blink-zero
Changed various settings tabs to match overall theme
aeaf30b
@blink-zero
Increased height of Playbook View modal and Edit Playbook modal
9738da7
@blink-zero
Updated various templates to match overall theme
b2ea721
@blink-zero
Fixed uploading image bug when uploading with suffix brackets on zip …
cbef5dc 
…filename
@blink-zero
Added History search for vm status db value
e82169b
@blink-zero
Modified links on home dashboard to filter to completed, running and …
a43ebf5 
…failed builds depending on what the user selects
@blink-zero
Removed Kali 2024.1 Image, This image will be moved to the community …
f14796c 
…images instead of being a default image
@blink-zero
Updated readme.md key features area
64477f8
@blink-zero
Fixed Server Error 500 on admin user deletion, flash message shown in…
89bea9f 
…stead
@blink-zero
Added password visability toggle for post deployment change password
1c54214
@blink-zero blink-zero self-assigned this Jul 30, 2024
@blink-zero blink-zero added the enhancement New feature or request label Jul 30, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 30, 2024
View reviewed changes
apps/static/js/non-domain.js
Comment on lines +134 to +142
card.innerHTML = `
<div class="card-body d-flex align-items-center p-3">
<img src="/static/images/64x64/${vm.imageiconname}" alt="${vm.imagetype}" class="vm-image-icon me-3">
<div class="flex-grow-1">
<h5 class="card-title mb-1">${vm.hostname}</h5>
<p class="card-text mb-0"><small>${vm.ipaddress} | ${vm.cpu} CPU | ${vm.ram} MB RAM</small></p>
</div>
</div>
`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
apps/static/js/domain.js
Comment on lines +120 to +128
card.innerHTML = `
<div class="card-body d-flex align-items-center p-3">
<img src="/static/images/64x64/${vm.imageiconname}" alt="${vm.imagetype}" class="vm-image-icon me-3">
<div class="flex-grow-1">
<h5 class="card-title mb-1">${vm.hostname}</h5>
<p class="card-text mb-0"><small>${vm.ipaddress} | ${vm.cpu} CPU | ${vm.ram} MB RAM</small></p>
</div>
</div>
`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 30, 2024
View reviewed changes
apps/home/routes.py
return jsonify({'success': True, 'message': 'VM restart initiated successfully.'})
except Exception as e:
log_json('ERROR', f'Failed to restart VM ID: {vm_id}', error=str(e))
return jsonify({'success': False, 'message': f'Failed to restart VM: {str(e)}'}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/settings/routes.py
except Exception as e:
db.session.rollback()
log_json('ERROR', 'VMware configuration update failed', error=str(e), traceback=traceback.format_exc())
return jsonify({'success': False, 'message': f'VMware configuration update failed: {str(e)}'}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/settings/routes.py
file.write(content)
return jsonify({'success': True, 'message': 'Playbook saved successfully'})
except Exception as e:
return jsonify({'success': False, 'message': str(e)}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/settings/routes.py
except Exception as e:
db.session.rollback()
log_json('ERROR', 'Template passwords update failed', error=str(e))
return jsonify({'success': False, 'message': f'Password update failed: {str(e)}'}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/settings/routes.py
except ssl.SSLError as e:
log_json('ERROR', 'VMware connection test failed: SSL error',
vcenter_server=vcenter_server, username=vcenter_username, error=str(e))
return jsonify({'success': False, 'message': f'SSL Error: {str(e)}. Consider using a valid SSL certificate or updating your SSL configuration.'}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/settings/routes.py
except Exception as e:
log_json('ERROR', 'VMware connection test failed',
vcenter_server=vcenter_server, username=vcenter_username, error=str(e))
return jsonify({'success': False, 'message': f'Connection failed: {str(e)}'}), 500

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
apps/home/routes.py
try:
output.append(f"Starting Linux update process for VM {vm_record.hostname}...")
ssh = paramiko.SSHClient()
ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())

Check failure

Code scanning / CodeQL

Accepting unknown SSH host keys when using Paramiko High

Setting missing host key policy to AutoAddPolicy may be unsafe.
apps/home/routes.py
ssh = None
try:
ssh = paramiko.SSHClient()
ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())

Check failure

Code scanning / CodeQL

Accepting unknown SSH host keys when using Paramiko High

Setting missing host key policy to AutoAddPolicy may be unsafe.
apps/home/routes.py
log_json('INFO', f"Started expand disk on {vm_record.hostname}", vm_id=vm_record.id)

ssh = paramiko.SSHClient()
ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())

Check failure

Code scanning / CodeQL

Accepting unknown SSH host keys when using Paramiko High

Setting missing host key policy to AutoAddPolicy may be unsafe.
@blink-zero blink-zero marked this pull request as ready for review July 30, 2024 08:40
@blink-zero blink-zero merged commit cedc380 into main Jul 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blink-zero blink-zero

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@blink-zero