Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds checking for Address #519

Closed
agaffney opened this issue Mar 9, 2024 · 0 comments · Fixed by #520
Closed

Add bounds checking for Address #519

agaffney opened this issue Mar 9, 2024 · 0 comments · Fixed by #520
Assignees

Comments

@agaffney
Copy link
Contributor

agaffney commented Mar 9, 2024

When investigating how we are effected by IntersectMBO/cardano-ledger#2729, I was surprised to find that we handled everything properly. This is because we're not checking any lengths and copying into unbounded byte slices.

We need to make sure that we're doing some sanity checks around sizes/lengths AND that we can also handle the case described in the other issue. This will probably mean silently storing the extra bytes from the address, but they will only be used when generating the bech32 representation of the address.

agaffney added a commit that referenced this issue Mar 9, 2024
@agaffney agaffney self-assigned this Mar 9, 2024
agaffney added a commit that referenced this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant