Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comment for Keys #42

Closed
goerz opened this issue Jun 25, 2016 · 5 comments
Closed

Allow comment for Keys #42

goerz opened this issue Jun 25, 2016 · 5 comments
Labels
feature Feature requested by users
Milestone

Comments

@goerz
Copy link

goerz commented Jun 25, 2016

When exporting a key from Blink, it does not have a trailing comment, e.g.

 ssh-rsa AAAAB...idtMZlnWy3trQ== goerz@blink_ipad

I would propose to add a 'comment' field in the Key Settings (underneath Name) that allows to define this comment. If not such comment is defined, I think at least the Name should be used as the comment.

@goerz
Copy link
Author

goerz commented Jun 26, 2016

I didn't realize that "Name" was actually the filename for the key (and should generally be id_rsa). That means that obviously, the Name should not give the default for the comment. It also makes a separate Comment field more relevant.

@carloscabanero carloscabanero added the feature Feature requested by users label Jun 27, 2016
@carloscabanero
Copy link
Member

Sold! Will add another text field for this, with a default to the user@device.

@carloscabanero
Copy link
Member

PT #122598341

@carloscabanero carloscabanero modified the milestone: Backlog Aug 17, 2016
@carloscabanero carloscabanero added the WIP Work In Progress label Aug 17, 2016
@carloscabanero carloscabanero added 2p and removed WIP Work In Progress labels Oct 12, 2016
@carloscabanero
Copy link
Member

atul3189 added a commit to atul3189/blink that referenced this issue Nov 2, 2016
@carloscabanero carloscabanero added the WIP Work In Progress label Nov 3, 2016
carloscabanero pushed a commit that referenced this issue Dec 9, 2016
Closes #42

Adds comment on public keys based on default user and device name.
@carloscabanero
Copy link
Member

Done!

@yury yury removed the WIP Work In Progress label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requested by users
Projects
None yet
Development

No branches or pull requests

3 participants