Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images do not render from Content Hub DAM #93

Closed
rkuchler opened this issue May 21, 2021 · 5 comments
Closed

Images do not render from Content Hub DAM #93

rkuchler opened this issue May 21, 2021 · 5 comments

Comments

@rkuchler
Copy link

Do you want to request a feature or report a bug?
This appears to be a bug.

What is the current behavior?
When calling either the Render method or the ImageFor method on an ImageField object the image files to render if it is sourced from the DAM.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install and configure the Sitecore Connect™ for Sitecore DAM 2.0 module in a Sitecore 9.3 XP solution
  2. Add an image field to any template
  3. Create an item based on that template
  4. In the content editor edit that item and click on the Browse Sitecore DAM link to add an image
  5. Preview the item and note that the image does not render

What is the expected behavior?
The image would render the same way it would if it were sourced from the media library

Please mention your Sitecore version and Synthesis version.
Sitecore 9.3
Synthesis 9.1.0.2

@blipson89
Copy link
Owner

Fixed in Synthesis 9.1.2

Thank you for the help @rkuchler

jroho added a commit to jroho/Synthesis that referenced this issue Jul 24, 2021
Overriding Url to ContentHubImageField
@jroho jroho mentioned this issue Jul 24, 2021
@jroho
Copy link
Contributor

jroho commented Jul 24, 2021

Do you want to request a feature or report a bug?
I think this issue needs to be reopened.

What is the current behavior?
This issue appears to persist when accessing Url from ContentHubImageField which is derived from IImageField :: FileField. I followed the instructions to implement ContentHubImageField, but there appears to be issues accessing Url, which is inherited from Synthesis.FieldTypes.Interfaces.IFileField, and IImageField. It's always null for images set from Content Hub.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install and configure the Sitecore Connect™ for Sitecore DAM 2.0 module in a Sitecore 9.3 XP solution
  2. Add an image field to any template
  3. Create an item based on that template
  4. In the content editor edit that item and click on the Browse Sitecore DAM link to add an image
  5. Preview the item and note that the image does not render
  6. Url property is always null for the ContentHubImageField (We don't use Render() or ImageFor() as we have a custom library that inherits from IImageField)

What is the expected behavior?
I would expect to be able to access data member, Url, from ContentHubImageField, derived from IImageField :: IFileField. I also added IsContentHub property to the IContentHubImageField interface. This property is useful when exposed here.

My pr does solve the issue for us (we are fully integrated with content hub), if you want to take a look: #97

Please mention your Sitecore version and Synthesis version.
Sitecore 9.3
Synthesis 9.1.0.2

@blipson89 blipson89 reopened this Jul 25, 2021
blipson89 pushed a commit that referenced this issue Jul 25, 2021
Overriding Url to ContentHubImageField
@blipson89
Copy link
Owner

Hi @jroho,

It looks like a potential fix was released a while ago but I forgot to follow up. Is this issue resolved?

Thanks,
Ben

@jroho
Copy link
Contributor

jroho commented Oct 11, 2022 via email

@blipson89
Copy link
Owner

Glad to hear it! I'm going to close this issue out then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants