New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for boost serialization #34
Conversation
When compiling with boost serialization versions 1.60.0 and up, one will get an error that boost can't access the memblock destructor. This adds the required friend statement for boost.
Thank you! Let me keep it open for a few days and add a new Boost example to the continuous integration build beforehand so the fix would then also be exemplified. |
I tried this program
On Ubuntu 18.04 gcc 7.3.0
Before fix:
After the fix, builds and runs with output:
Ok, that last number isn't right... I never tried it with a stringstream before. Oddly, it fails to link with boost serialization unless I put the -lboost_serialization after the cpp file name. Also note, the error only occurs when using the input archive; I tried it first with only the output archive and it compiled. |
thank you! |
@slayoo Can we merge this? |
As above, I vote for adding at least a minimalistic test case |
Since this fixes a compilation error, it doesn't seem amenable for addition to the test suite. |
Sorry, here's a PR that should hopefully fix the merge conflict: #165 |
merged, thank you! |
When compiling with boost serialization versions 1.60.0 and up, one will
get an error that boost can't access the memblock destructor. This adds
the required friend statement for boost.