Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why page out transition is not on beforeunload event ? #1

Closed
gauravpadia opened this issue Jun 28, 2014 · 13 comments
Closed

why page out transition is not on beforeunload event ? #1

gauravpadia opened this issue Jun 28, 2014 · 13 comments

Comments

@gauravpadia
Copy link
Collaborator

Hey @blivesta ,

Thanks for this great script. I am developing a wordpress plugin based on your clickstream script.

I saw that if I want to add page out transition on all pages then I need to add class "clickstream-link" on all "a" link tags.

Is there any specific reason for this ? Why did you not used onbeforeunload event ?
Is there any other way to add page out transition ?

Can you please through some light on it ?

Thanks.

Kind Regards,
Gaurav Padia

@blivesta
Copy link
Owner

Thanks @gauravpadia

The reason you have to click event.
Because I thought that there is a need to control the page until the transition from by clicking on the link.
And I would like to be able to set the animation different per each "a" tag in the future.

It works by adding the options as follows: To operate in "a" tag of all.

  • Add after the "clickstream-link".
$(".clickstream").clickstream ({
  linkClass: 'clickstream-link, a' 
}); 

@gauravpadia
Copy link
Collaborator Author

@blivesta Ok fine. Got it. Any plans to add more transition effects ?

Thanks.

@blivesta
Copy link
Owner

@gauravpadia There is no plan at the moment, but I will consider if there is a requests.

@blivesta
Copy link
Owner

blivesta commented Jul 2, 2014

@gauravpadia
Changing the name of the repository and plug-in

@gauravpadia
Copy link
Collaborator Author

@blivesta
Oh okay fine but may I just ask why ?
Already done ? Please let me know new name and repository link if already moved under new name.
Thanks.

@gauravpadia
Copy link
Collaborator Author

@blivesta
I am sorry if I miss understood. Are you referring to latest changes you made in repository ? I mean changes you made in title of the plugin "clickstream" to "clickstream.js" ?

Sorry for confusion.

Thanks.

@blivesta
Copy link
Owner

blivesta commented Jul 3, 2014

@gauravpadia
It does not change the name yet.
I am going to change the future.

This is because the "clickstream" The reason you want to change the name is also used in terms of analysis.
https://twitter.com/search?q=clickstream&src=typd

thanks

@gauravpadia
Copy link
Collaborator Author

@blivesta
Oh okay fine. Please let me know when you change it. I hope you are doing it very soon as I am creating a free wordpress plugin based on your script.

Edit: I mean to say I hope you are not doing it very soon.

Thanks.

@blivesta
Copy link
Owner

blivesta commented Jul 5, 2014

@gauravpadia
changed the name to animsition.
And I'm looking forward to WP plug-in that you are developing.
Thanks.

@gauravpadia
Copy link
Collaborator Author

@blivesta
Okay great.
Do check new issue I created #4

@gauravpadia
Copy link
Collaborator Author

@blivesta
I just loaded page transition plugin for wordpress with your jquery plugin. Here is the link - http://wordpress.org/plugins/page-transition/

Please let me have your feedback.

@blivesta
Copy link
Owner

@gauravpadia
Great.
I will consider adding the option of duration management in future animsition.

@gauravpadia
Copy link
Collaborator Author

@blivesta Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants