Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

0.8.9 #12

Closed
wants to merge 9 commits into from
Closed

0.8.9 #12

wants to merge 9 commits into from

Conversation

mystix
Copy link
Contributor

@mystix mystix commented Nov 27, 2012

  • added modman file
  • fixed css file path (tested in magento 1.7+)
  • bugfix: Custom Columns #2 (courtesy of @digiscape)
  • made image width / height optional
  • added row highlight on mouseover / drag
  • added bugfix for chrome setting cursor to "text" while dragging

@paales
Copy link

paales commented May 13, 2013

To improve the chances that this pull request will be merged, I would suggest cleaning it up. You can do this by:

  • removing all the whitespace changes
  • Make the pullrequest more about a single issue instead of updating multiple issues at the same time

@mage-eag
Copy link
Collaborator

Thanks for all those commits !

  • fixed css file path : fixed by 946f155 (made compatible with 1.6 and previous versions)
  • bugfix: https://github.com/mage-eag/mage-enhanced-admin-grids/issues/2 : 1b94e4c brought a new way of handling callbacks that should hopefully fix the problem
  • made image width / height optional : didn't apply it yet, as this would only work for browser resize (width and height are both required when the images need to actually be resized)
  • call event.preventDefault when dragging is started : added by aa32607
  • added row highlight on mouseover and drag : added by b9ae095
  • Fixes Notice: "Undefined variable: grid [..] : fixed by 3f721aa
  • Fix strict notice caused by passing the return value of a function [..] : fixed by aa2ab7e

@mage-eag mage-eag closed this May 16, 2013
@mystix
Copy link
Contributor Author

mystix commented May 17, 2013

Thanks @mage-eag for pulling my (really messy - apologies for that) requests!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants