Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

1.0.0 wip edge #271

Open
wants to merge 163 commits into
base: 0.9.0
Choose a base branch
from
Open

1.0.0 wip edge #271

wants to merge 163 commits into from

Conversation

LEEJUNESEOK
Copy link

I using 1.0.0 version.

Looks it has bug, Can you check it?
BL/CustomGrid/Block/Widget/Grid/Column/Renderer/Text.php

56 Line

`if (($truncationMode = $this->getColumn()->getTruncationMode())
&& ($truncationMode != self::TRUNCATION_MODE_NONE)) {
/** @var $stringHelper BL_CustomGrid_Helper_String */
$stringHelper = $this->helper('customgrid/string');
$truncationLength = (int) $this->getColumn()->getTruncationAt();
$truncationEnding = $this->getColumn()->getTruncationEnding();
$exactTruncation = (bool) $this->getColumn()->getExactTruncation();
$remainder = '';

        if ($truncationMode == self::TRUNCATION_MODE_HTML) {
            $textValue = $stringHelper->truncateHtml(
                $textValue,
                $truncationLength,
                $truncationEnding,
                !$exactTruncation
            );
        } elseif ($truncationMode == self::TRUNCATION_MODE_TEXT) {
            $textValue = $stringHelper->truncateText(
                $textValue,
                $truncationLength,
                $truncationEnding,
                $remainder,
                !$exactTruncation
            );              
        }
    }

`
$truncationLength value always 0,
$truncationEnding also empty.

It related with adding text field grid > rendering > truncation setting in catalog/product page.
$truncationMode return right value as setting,
but 'Truncate at n-th character', 'Truncate ending string' value doesn't return it.

as it result, when Truncate => yes, custom field show empty value. ( truncationLength==0, return '' )
I tested it php7 and php 5.6

- when added multiple times for a same store view, attributes are now only joined once
- fix for renderer default values
…ns <select> (left-click to go to a profile, right-click to view all the available actions)
- reworked the output of the messages block
- fixed a typo preventing from copying default parameters from one profile to another
- rearranged fields in configuration windows
- implemented advanced possibilities for options columns filtering
- various fixes for the options sources
- some code cleanup
…from the options renderer

- same thing for the "Status (With Color)" custom column from the orders grid
- various fixes for the custom columns with a locked renderer
- little cleanup in the custom columns code
- added one forgotten file (needed for togglable fieldsets)
- started reducing of cyclomatic and NPath complexities
- big design and usability rework (including various improvements and new customization options)
- introduced the possibility to edit the forced grid types
- reworked the grid block and collection verifications for custom columns (not blocking anymore by default)
- various bug fixes
- small README.md change
- fixed a warning
- improved the grid edit page
- completed 1.0.0 setup file, bumped version accordingly
- more code cleanup / refactoring
- reduced code duplication
- reduced complexity of BL_CustomGrid_Model_Grid
- reduced complexity BL_CustomGrid_Model_Custom_Column_Abstract
- various fixes
- various fixes
- implemented inventory columns editability
- implemented the most common use cases of BL_CustomGrid_Model_Grid_Editor_Value_Config as actual methods
- fixed the custom columns form
- refactored a part of the BL_CustomGrid_Model_Grid_Rewriter_Abstract class
- other small fixes
…void cluttering any external wrapping form with a lot of parameters, making it exceed the maximum variables limit)
… default renderer now dispatches the rendering to the new blocks depending on the field type)
…orker models

- improved consistency for methods naming / comments
- small fixes
@seansan
Copy link

seansan commented May 4, 2017

$truncationLength value always 0,
$truncationEnding also empty.

I do not see this. Does have value.

In this image Ending is hyphen which is correct
Lenght tested too was also correct

However: I do agree that even then - it does not work as expected .... that we see also.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants