Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - Sidebar Follow Request Icon Missing #18

Closed
daw50n opened this issue Nov 8, 2023 · 2 comments
Closed

Issue - Sidebar Follow Request Icon Missing #18

daw50n opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@daw50n
Copy link

daw50n commented Nov 8, 2023

When user gets a new follower request the sidebar adds a menu for this, with any theme activated an icon is not shown for the sidebar menu entry

Screenshot 2023-11-08 at 08 39 42
blobcatz added a commit that referenced this issue Nov 8, 2023
@blobcatz blobcatz closed this as completed Nov 8, 2023
@daw50n
Copy link
Author

daw50n commented Nov 8, 2023

Agree fix is now present, but when followe requests in the sidebar are selected is the purple colour in keeping with other themed icons?

Screenshot from 2023-11-08 20-56-03

Screenshot from 2023-11-08 20-56-35

@blobcatz
Copy link
Owner

blobcatz commented Nov 8, 2023

My idea was for bookmarks and favorites to have the same color as they are both post-related features and display posts you liked/bookmarked. That's also why the icon for "Explore" is different too. And it's not really "keeping with other themed icons" since "Private mentions", "Live feeds", and "Notifications" also have different colors, the only exception is the "Home" icon.
TLDR: It's a design choice

@blobcatz blobcatz added the bug Something isn't working label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants