remove hole feature

A hole feature is something needed, however, the current implementation does not use the attacher code which would made it intuitive and compatibel to other workbench tools. A reimplementation is needed.
blobfish · Jul 18, 2015 · 5f127b6 · 5f127b6
1 parent 5cc4c12
commit 5f127b6
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 24 deletions.
diff --git a/src/Mod/PartDesign/App/AppPartDesign.cpp b/src/Mod/PartDesign/App/AppPartDesign.cpp
@@ -47,7 +47,7 @@
 #include "FeaturePolarPattern.h"
 #include "FeatureScaled.h"
 #include "FeatureMultiTransform.h"
-#include "FeatureHole.h"
+//#include "FeatureHole.h"
 #include "DatumPlane.h"
 #include "DatumLine.h"
 #include "DatumPoint.h"
@@ -96,7 +96,7 @@ void PartDesignExport init_PartDesign()
     PartDesign::PolarPattern       ::init();
     PartDesign::Scaled             ::init();
     PartDesign::MultiTransform     ::init();
-    PartDesign::Hole               ::init();
+    //PartDesign::Hole               ::init();
     PartDesign::Body               ::init();
     PartDesign::Pad                ::init();
     PartDesign::Pocket             ::init();

diff --git a/src/Mod/PartDesign/CMakeLists.txt b/src/Mod/PartDesign/CMakeLists.txt
@@ -89,17 +89,17 @@ SET(FeatureHole_UI
 
 SET(all_featurehole_files ${FeatureHole_SRCS} ${FeatureHole_UI})
 
-ADD_CUSTOM_TARGET(FeatureHole ALL
-    SOURCES ${all_featurehole_files}
-)
+#ADD_CUSTOM_TARGET(FeatureHole ALL
+#    SOURCES ${all_featurehole_files}
+#)
 
-SET(all_files ${all_featurehole_files})
+#SET(all_files ${all_featurehole_files})
 
 fc_copy_sources(Mod/PartDesign "${CMAKE_BINARY_DIR}/Mod/PartDesign" ${all_files})
 
-INSTALL(
-    FILES
-        ${FeatureHole_SRCS}
-    DESTINATION
-        Mod/PartDesign/FeatureHole
-)
+#INSTALL(
+#    FILES
+#        ${FeatureHole_SRCS}
+#    DESTINATION
+#        Mod/PartDesign/FeatureHole
+#)
diff --git a/src/Mod/PartDesign/Gui/CMakeLists.txt b/src/Mod/PartDesign/Gui/CMakeLists.txt
@@ -37,7 +37,7 @@ set(PartDesignGui_MOC_HDRS
     TaskDraftParameters.h
     TaskThicknessParameters.h
     TaskDressUpParameters.h
-    TaskHoleParameters.h
+    #TaskHoleParameters.h
     TaskRevolutionParameters.h
     TaskGrooveParameters.h
     TaskTransformedMessages.h
@@ -67,7 +67,7 @@ set(PartDesignGui_UIC_SRCS
     TaskDraftParameters.ui
     TaskThicknessParameters.ui
     TaskBooleanParameters.ui
-    TaskHoleParameters.ui
+    #TaskHoleParameters.ui
     TaskRevolutionParameters.ui
     TaskGrooveParameters.ui
     TaskTransformedMessages.ui
@@ -92,8 +92,8 @@ SET(PartDesignGuiViewProvider_SRCS CommandPrimitive.cpp
     ViewProviderBody.h
     ViewProviderPad.cpp
     ViewProviderPad.h
-    ViewProviderHole.cpp
-    ViewProviderHole.h
+    #ViewProviderHole.cpp
+    #ViewProviderHole.h
     ViewProviderPocket.cpp
     ViewProviderPocket.h
     ViewProviderChamfer.cpp
@@ -199,9 +199,9 @@ SET(PartDesignGuiTaskDlgs_SRCS
     TaskMultiTransformParameters.ui
     TaskMultiTransformParameters.cpp
     TaskMultiTransformParameters.h
-    TaskHoleParameters.ui
-    TaskHoleParameters.cpp
-    TaskHoleParameters.h
+    #TaskHoleParameters.ui
+    #TaskHoleParameters.cpp
+    #TaskHoleParameters.h
     TaskDatumParameters.ui
     TaskDatumParameters.cpp
     TaskDatumParameters.h

diff --git a/src/Mod/PartDesign/Gui/Workbench.cpp b/src/Mod/PartDesign/Gui/Workbench.cpp
@@ -779,7 +779,8 @@ Gui::MenuItem* Workbench::setupMenuBar() const
           << "Separator"
           << "PartDesign_Boolean"
           << "Separator"
-          << "PartDesign_Hole";
+          //<< "PartDesign_Hole"
+          << "PartDesign_InvoluteGear";
 
     // For 0.13 a couple of python packages like numpy, matplotlib and others
     // are not deployed with the installer on Windows. Thus, the WizardShaft is

diff --git a/src/Mod/PartDesign/InitGui.py b/src/Mod/PartDesign/InitGui.py
@@ -80,10 +80,10 @@ def Initialize(self):
                     import InvoluteGearFeature
                 except ImportError:
                     print "Involute gear module cannot be loaded"
-                try:
-                    from FeatureHole import HoleGui
-                except:
-                    pass
+                #try:
+                #    from FeatureHole import HoleGui
+                #except:
+                #    pass
 
         def GetClassName(self):
                 return "PartDesignGui::Workbench"